Skip to content

fix(event-handler): ignore return type from onSubscribe handler #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged

fix(event-handler): ignore return type from onSubscribe handler #3888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/event-handler/src/appsync-events/AppSyncEventsResolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,7 @@ class AppSyncEventsResolver extends Router {
}
const { handler } = routeHandlerOptions;
try {
return await (handler as OnSubscribeHandler).apply(this, [
event,
context,
]);
await (handler as OnSubscribeHandler).apply(this, [event, context]);
} catch (error) {
this.logger.error(`An error occurred in handler ${path}`, error);
if (error instanceof UnauthorizedException) throw error;
Expand Down
4 changes: 2 additions & 2 deletions packages/event-handler/tests/unit/AppSyncEventsResolver.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ describe('Class: AppSyncEventsResolver', () => {
expect(result).toEqual(null);
});

it('returns the response of the onSubscribe handler', async () => {
it('ignores the response of the onSubscribe handler', async () => {
// Prepare
const app = new AppSyncEventsResolver({ logger: console });
app.onSubscribe('/foo', async () => true);
Expand All @@ -87,7 +87,7 @@ describe('Class: AppSyncEventsResolver', () => {
);

// Assess
expect(result).toBe(true);
expect(result).toBe(undefined);
});

it.each([
Expand Down
Loading