Skip to content

chore: pin version of commons dependency #3880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025
Merged

Conversation

dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR updates the package.json for all utilities that depend on the commons package so that they now require the same version of the package as their own.

Since we version all our utilities together, this ensures that whenever there's an update to commons that updated version is installed with the correct version of each utility. Prior to this fix, the version range used the ^ symbol, which meant that depending on how customers updated a utility (i.e. logger) npm might not have updated commons in case of a minor version update.

The change should be seamless and not require any change on the customer side, since it'll be effective starting from the next release.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: fixes #3879


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this May 1, 2025
@boring-cyborg boring-cyborg bot added the dependencies Changes that touch dependencies, e.g. Dependabot, etc. label May 1, 2025
@pull-request-size pull-request-size bot added the size/S PR between 10-29 LOC label May 1, 2025
Copy link

sonarqubecloud bot commented May 1, 2025

@dreamorosi dreamorosi merged commit a57634c into main May 1, 2025
47 checks passed
@dreamorosi dreamorosi deleted the chore/commons_version branch May 1, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc. size/S PR between 10-29 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: require specific commons version as dependency
2 participants