fix(logger): display correct log level in cloudwatch #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saragerion
commented
Jan 3, 2022
| return; | ||
| } | ||
| this.printLog(this.createAndPopulateLogItem('DEBUG', input, extraInput)); | ||
| this.processLogItem('DEBUG', input, extraInput); |
There was a problem hiding this comment.
Housekeeping: removed unnecessary code duplication
saragerion
commented
Jan 3, 2022
| log.prepareForPrint(); | ||
|
|
||
| const consoleMethod = logLevel.toLowerCase() as keyof ClassThatLogs; | ||
|
|
||
| console[consoleMethod](JSON.stringify(log.getAttributes(), this.removeCircularDependencies())); |
There was a problem hiding this comment.
Here I:
- Removed the JSON parse step so that the log items will be displayed more nicely (green coloured values) in cloudwatch (see image)
- Moved the circular reference logic to its own method so make it easier to read, adding relevant jsdocs documentation and separate responsibilities
saragerion
added
bug
saragerion
changed the title
dreamorosi
approved these changes
Jan 3, 2022
ijemmy
approved these changes
Jan 3, 2022
| * @see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Cyclic_object_value | ||
| * @private | ||
| */ | ||
| private removeCircularDependencies(): (key: string, value: LogAttributes) => void { |
There was a problem hiding this comment.
💯 This is much easier to read and understand.
flochaz
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes: #378
How to verify this change
Related issues, RFCs
#378
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.