fix(logger): warn only once on ALC log level mismatch #3816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
logger
|
am29d
approved these changes
Apr 8, 2025
There was a problem hiding this comment.
Thanks for the quick fix!
✅ e2e tests: https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/14333635580
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR implements a new internal behavior for Logger that adds the ability to log a warning only once per logger instance.
Besides the new behavior described above, the PR also addresses another bug described in the linked issue which caused the Logger to not save the Advanced Logging Controls log level upon initialization, which in turns caused the warning to be emitted when log sampling was refreshed.
Issue number: fixes #3815
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.