Skip to content

fix(metrics): expose logMetrics middleware #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2022
Merged

fix(metrics): expose logMetrics middleware #380

merged 1 commit into from
Jan 3, 2022

Conversation

flochaz
Copy link
Contributor

@flochaz flochaz commented Jan 3, 2022

Description of your changes

Middleware was not exposed properly

How to verify this change

cd packages/metrics
npm ci
npm run test

Related issues, RFCs

#379

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

saragerion
saragerion approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@saragerion saragerion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flochaz flochaz changed the title fix(metrics) expose logMetrics middleware fix(metrics): expose logMetrics middleware Jan 3, 2022
@dreamorosi dreamorosi added bug Something isn't working metrics This item relates to the Metrics Utility labels Jan 3, 2022
@dreamorosi dreamorosi added this to the beta-release milestone Jan 3, 2022
@dreamorosi dreamorosi linked an issue Jan 3, 2022 that may be closed by this pull request
Bug: Metrics Middy middleware not exported #379
Closed
@flochaz flochaz merged commit 6107725 into main Jan 3, 2022
@flochaz flochaz deleted the fix/metrics/middlewareExport branch January 3, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijemmy ijemmy ijemmy approved these changes

@dreamorosi dreamorosi dreamorosi approved these changes

@saragerion saragerion saragerion approved these changes

Assignees

@flochaz flochaz

Labels
bug Something isn't working metrics This item relates to the Metrics Utility
Projects
None yet
Milestone
beta-release
Development

Successfully merging this pull request may close these issues.

Bug: Metrics Middy middleware not exported
4 participants
@flochaz @ijemmy @dreamorosi @saragerion