fix(parser): ddb base schema + other exports #3741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
dependencies
am29d
requested changes
Mar 19, 2025
Co-authored-by: Alexander Schueren <[email protected]>
|
am29d
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR fixes the missing export discussed in the linked issue and also takes the opportunity to review the overall structure of the Parser exports to simplify it and provide a better IDE experience for customers.
While doing so, I also updated the structure of the files within the package to more closely align with the exports, which allows us to use star exports more effectively (i.e.
@aws-lambda-powertools/parser/schemas/<module-name>). This required some import changes, mainly in tests, which made the diff big.Finally, I also reviewed all the example snippets and made sure they all use scoped sub-path exports rather than the barrel file export. This way customers copying the snippet from the code will have a smaller bundle size, since they'll be importing only the schemas/envelopes that they're actually using rather than all of them. This also increased the diff considerably.
Issue number: fixes #3740
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.