refactor(logger): align implementation to spec + docs #3701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
documentation
pull-request-size
bot
added
the
size/XL
github-actions
bot
added
the
enhancement
|
leandrodamascena
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR aligns the implementation of the log buffering feature in Logger so that it aligns with the spec defined in the RFC. The implementation we got to differed slightly in a couple of important ways, namely:
This PR addresses these two differences and slightly refactors some of the internal props in the Logger related to the new feature so that they are all grouped together.
The PR also adds the documentation for the feature, largely mirroring the version written in aws-powertools/powertools-lambda-python#6060.
Integration tests will be added in a future PR in this iteration.
Issue number: closes #3700
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.