chore(maintenance): simplify Utility class #3682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
boring-cyborg
bot
added
commons
|
End to end tests for this branch are green: https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/13627970971 |
leandrodamascena
requested changes
Mar 3, 2025
There was a problem hiding this comment.
Hi @dreamorosi! I think after updating the docstring it's good to merge.
leandrodamascena
approved these changes
Mar 3, 2025
|
|
Hi, not sure where to post but version 2.16.0 is introducing a breaking change by remove the protected getDefaultServiceName() function from Utility. Because the logger library is using the common package with the ^ version allowing for minor upgrade, all installations of the powertool/logger pre 2.16.0 will now fail to run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR updates the implementation of the shared
Utilityclass to streamline it and remove redundant methods.Issue number: closes #3668
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.