Skip to content

fix(batch): clear message group references after request #3674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR fixes a bug in Batch Processing where the internal state of the processor would not get reset after each invocation, causing messages from group ids that had previously failed to get skipped.

The PR updates the processor by clearing the state before processing the next batch.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: fixes #3673


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Feb 27, 2025
@dreamorosi dreamorosi requested review from a team as code owners February 27, 2025 15:48
@dreamorosi dreamorosi requested a review from am29d February 27, 2025 15:48
@boring-cyborg boring-cyborg bot added batch This item relates to the Batch Processing Utility tests PRs that add or change tests labels Feb 27, 2025
@pull-request-size pull-request-size bot added the size/M PR between 30-99 LOC label Feb 27, 2025
@github-actions github-actions bot added the bug Something isn't working label Feb 27, 2025
@am29d am29d merged commit 270115e into main Feb 27, 2025
49 checks passed
@am29d am29d deleted the fix/batch_messagegroup_refresh branch February 27, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch This item relates to the Batch Processing Utility bug Something isn't working size/M PR between 30-99 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Retry of previously failed SQS record is skipped when skipGroupOnError is enabled
2 participants