-
Notifications
You must be signed in to change notification settings - Fork 154
chore(ci): adopt new CDK Toolkit Library #3665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
am29d
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, and super fast adoption! E2E tests are green locally and in CICD. 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automation
This item relates to automation
dependencies
Changes that touch dependencies, e.g. Dependabot, etc.
size/M
PR between 30-99 LOC
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR replaces the usage of the
@aws-cdk/cli-lib-alpha
with the newer@aws-cdk/toolkit-lib
that was announced in developer preview earlier today.This new toolkit is expected to be the way of interacting with CDK programmatically moving forward, so it makes sense for us to adopt it and remove the older
@aws-cdk/cli-lib-alpha
.The switch is pretty much a drop-in replacement for us, since we were already abstracting away the CLI from the tests. The bulk of the changes are in the
TestStack
class in the internaltesting
package, which now uses the new module.With this new toolkit we unlocked also two new benefits:
latest
dist tag on npmjs.com it can now be picked up by Dependabot update, this was not the case with the@aws-cdk/cli-lib-alpha
which was using a pre-release tag.Finally, while not related to the new toolkit, I also changed the stack generation to include a
Service
tag to all resources generated as part unit test runs. This was something that I had in the backlog for a while and that will unlock some additional automation down the road. For example, now that things are tagged, we can potentially automate the removal of CloudWatch LogGroup resources, which currently are just piling up. More info on this front in the near future.Issue number: closes #3117
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.