Skip to content

improv(parser): allow extending base provider with no AWS SDK client #3564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR improves slightly the experience in Parameters by allowing customers to create custom providers without having to specify a no-op parameter.

In addition to doing this, I also renamed the parameter to awsSdkV3ClientPrototype for added clarity, and improved the documentation around it.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #2400


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Feb 6, 2025
@dreamorosi dreamorosi requested a review from a team February 6, 2025 12:04
@dreamorosi dreamorosi requested a review from a team as a code owner February 6, 2025 12:04
@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation parameters This item relates to the Parameters Utility labels Feb 6, 2025
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Feb 6, 2025
Copy link

sonarqubecloud bot commented Feb 6, 2025

@github-actions github-actions bot added the enhancement PRs that introduce minor changes, usually to existing features label Feb 6, 2025
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dreamorosi! Just a comment that I think makes sense to read before approving the PR.

@dreamorosi dreamorosi merged commit c85b90a into main Feb 6, 2025
46 checks passed
@dreamorosi dreamorosi deleted the improv/allow_base_parameters_no_client branch February 6, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement PRs that introduce minor changes, usually to existing features parameters This item relates to the Parameters Utility size/L PRs between 100-499 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: allow BaseProvider in Parameters to not have a client
2 participants