Skip to content

chore: migrate to vitest v3 #3561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 6, 2025
Merged

chore: migrate to vitest v3 #3561

merged 3 commits into from
Feb 6, 2025

Conversation

dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR upgrades Vitest and its dependencies to the v3 version. This upgrade included some breaking changes that affected some of the tests in our project. This means I had to make some minor changes to our tests.

The changes in Vitest v3 are listed here, but for our project the interesting parts are around error matchers and how the state of spies/mocks is managed.

While working on this upgrade, thanks to the changes in how errors are matched, I was able to uncover a test that was written incorrectly in the Idempotency tests.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #3490


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Feb 5, 2025
@boring-cyborg boring-cyborg bot added dependencies Changes that touch dependencies, e.g. Dependabot, etc. documentation Improvements or additions to documentation tests PRs that add or change tests labels Feb 5, 2025
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Feb 5, 2025
@dreamorosi
Copy link
Contributor Author

I ran the integration tests on this branch, and are passing.

Copy link

sonarqubecloud bot commented Feb 5, 2025

@dreamorosi dreamorosi marked this pull request as ready for review February 5, 2025 18:45
@dreamorosi dreamorosi requested a review from a team February 5, 2025 18:45
@dreamorosi dreamorosi requested a review from a team as a code owner February 5, 2025 18:45
@dreamorosi dreamorosi merged commit 4538d73 into main Feb 6, 2025
38 checks passed
@dreamorosi dreamorosi deleted the chore/bump_vitest branch February 6, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc. documentation Improvements or additions to documentation size/L PRs between 100-499 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: vitest major bump to 3.x
2 participants