fix(parser): allow VPC envelopes to handle non-JSON strings #3534
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR updates the implementation of both the VPC Lattice v1 & v2 envelopes so that they don't try transform the body of the request as JSON without the customer explicitly passing a schema that does so.
This allows customers to handle plain text or base64-encoded as well.
In this PR I also removed the
@anatine/zod-mock
dependency, moved thepackages/parser/tests/schemas/util.js
file to its own folder atpackages/parser/tests/helpers/util.js
, and removed theEnvelope
implementation since this was the last set of built-in envelopes using it. These three changes account for 90% of the diff.Also with this PR we should be done with the major refactoring of the Parser envelopes. There are still a few things we should address like improving the docstrings of some envelopes/schemas, improving the docs of the utility, and creating sub-path exports for each set of envelopes like we did for the built-in schemas - but we'll do this in the next releases.
Issue number: fixes #3533
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.