Skip to content

fix(parser): set min length of 1 to s3 event lists #3524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR expands the work in #3521 and applies the minimum-length requirement of 1 to S3 events that have a shape of { "Records": [...] }.

The PR also continues the standardization of the unit tests which are now simplified.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #3475


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Jan 24, 2025
@dreamorosi dreamorosi requested a review from a team January 24, 2025 09:12
@dreamorosi dreamorosi requested a review from a team as a code owner January 24, 2025 09:12
@boring-cyborg boring-cyborg bot added parser This item relates to the Parser Utility tests PRs that add or change tests labels Jan 24, 2025
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Jan 24, 2025
@github-actions github-actions bot added the bug Something isn't working label Jan 24, 2025
@dreamorosi dreamorosi merged commit 937be64 into main Jan 24, 2025
38 checks passed
@dreamorosi dreamorosi deleted the fix/s3_min_fields branch January 24, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser This item relates to the Parser Utility size/L PRs between 100-499 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: parser built-in schema accept empty Records array
2 participants