Skip to content

feat(logger): change visibility to protected #3377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 29, 2024
Merged

feat(logger): change visibility to protected #3377

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
64d5e96
feat(logger): change visibility to protected
zirkelc Nov 28, 2024
6012df9
feat(logger): todo
zirkelc Nov 28, 2024
6d4eacb
revert: protected
zirkelc Nov 28, 2024
42d7708
revert: remove comment
zirkelc Nov 28, 2024
84d505a
Merge branch 'main' into protected-methods
dreamorosi Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/logger/src/Logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ class Logger extends Utility implements LoggerInterface {
/**
* JSON indentation used to format the logs.
*/
private logIndentation: number = LogJsonIndent.COMPACT;
protected logIndentation: number = LogJsonIndent.COMPACT;
/**
* Log level used internally by the current instance of Logger.
*/
Expand Down Expand Up @@ -700,7 +700,7 @@ class Logger extends Utility implements LoggerInterface {
* @param input - The main input of the log item, this can be a string or an object with additional attributes
* @param extraInput - Additional attributes to be added to the log item
*/
private createAndPopulateLogItem(
protected createAndPopulateLogItem(
logLevel: number,
input: LogItemMessage,
extraInput: LogItemExtraInput
Expand Down Expand Up @@ -783,7 +783,7 @@ class Logger extends Utility implements LoggerInterface {
*
* @param logLevel - The log level to get the name of
*/
private getLogLevelNameFromNumber(logLevel: number): Uppercase<LogLevel> {
protected getLogLevelNameFromNumber(logLevel: number): Uppercase<LogLevel> {
let found: Uppercase<LogLevel> | undefined;
for (const [key, value] of Object.entries(LogLevelThreshold)) {
if (value === logLevel) {
Expand Down Expand Up @@ -835,7 +835,7 @@ class Logger extends Utility implements LoggerInterface {
* @param logLevel - The log level
* @param log - The log item to print
*/
private printLog(logLevel: number, log: LogItem): void {
protected printLog(logLevel: number, log: LogItem): void {
log.prepareForPrint();

const consoleMethod =
Expand All @@ -846,6 +846,7 @@ class Logger extends Utility implements LoggerInterface {
'critical'
>);

// TODO: make this.console protected or create getConsole/getConsoleMethod?
this.console[consoleMethod](
JSON.stringify(
log.getAttributes(),
Expand All @@ -862,7 +863,7 @@ class Logger extends Utility implements LoggerInterface {
* @param input - The log message
* @param extraInput - The extra input to log
*/
private processLogItem(
protected processLogItem(
logLevel: number,
input: LogItemMessage,
extraInput: LogItemExtraInput
Expand Down