Skip to content

chore(parser): return correct type for safeParse in envelopes #3339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 22, 2024
Merged

chore(parser): return correct type for safeParse in envelopes #3339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
de1c104
fix(parser): properly parse eventbridge envelope when using safeParse
jharlow Nov 21, 2024
b8081be
fix(parser): properly parse lambdafunctionurl envelope when using saf…
jharlow Nov 22, 2024
fd9d36e
fix(parser): properly parse vpclattice envelopes when using safeParse
jharlow Nov 22, 2024
48b962c
Merge branch 'main' into fix/event-bridge-safe-parse-infer
am29d Nov 22, 2024
4d155a7
Merge branch 'main' into fix/event-bridge-safe-parse-infer
am29d Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/parser/src/envelopes/envelope.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const Envelope = {
* @param input
* @param schema
*/
safeParse<T extends ZodSchema>(input: unknown, schema: T): ParsedResult {
safeParse<T extends ZodSchema>(input: unknown, schema: T): ParsedResult<unknown, z.infer<T>> {
try {
if (typeof input !== 'object' && typeof input !== 'string') {
return {
Expand Down
2 changes: 1 addition & 1 deletion packages/parser/src/envelopes/event-bridge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const EventBridgeEnvelope = {
return Envelope.parse(EventBridgeSchema.parse(data).detail, schema);
},

safeParse<T extends ZodSchema>(data: unknown, schema: T): ParsedResult {
safeParse<T extends ZodSchema>(data: unknown, schema: T): ParsedResult<unknown, z.infer<T>> {
const parsedEnvelope = EventBridgeSchema.safeParse(data);

if (!parsedEnvelope.success) {
Expand Down
2 changes: 1 addition & 1 deletion packages/parser/src/envelopes/lambda.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const LambdaFunctionUrlEnvelope = {
return Envelope.parse(parsedEnvelope.body, schema);
},

safeParse<T extends ZodSchema>(data: unknown, schema: T): ParsedResult {
safeParse<T extends ZodSchema>(data: unknown, schema: T): ParsedResult<unknown, z.infer<T>> {
const parsedEnvelope = LambdaFunctionUrlSchema.safeParse(data);

if (!parsedEnvelope.success) {
Expand Down
2 changes: 1 addition & 1 deletion packages/parser/src/envelopes/vpc-lattice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const VpcLatticeEnvelope = {
return Envelope.parse(parsedEnvelope.body, schema);
},

safeParse<T extends ZodSchema>(data: unknown, schema: T): ParsedResult {
safeParse<T extends ZodSchema>(data: unknown, schema: T): ParsedResult<unknown, z.infer<T>> {
const parsedEnvelope = VpcLatticeSchema.safeParse(data);
if (!parsedEnvelope.success) {
return {
Expand Down
2 changes: 1 addition & 1 deletion packages/parser/src/envelopes/vpc-latticev2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export const VpcLatticeV2Envelope = {
return Envelope.parse(parsedEnvelope.body, schema);
},

safeParse<T extends ZodSchema>(data: unknown, schema: T): ParsedResult {
safeParse<T extends ZodSchema>(data: unknown, schema: T): ParsedResult<unknown, z.infer<T>> {
const parsedEnvelope = VpcLatticeV2Schema.safeParse(data);
if (!parsedEnvelope.success) {
return {
Expand Down