feat(parser): add schema for DynamoDB - Kinesis Stream event #3328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions for DynamoDB stream events
…eam-events-via-Kinesis-Data-Stream
boring-cyborg
bot
added
documentation
github-actions
bot
added
the
feature
dreamorosi
requested changes
Nov 18, 2024
…eam-events-via-Kinesis-Data-Stream
dreamorosi
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Looking good, just a couple minor comments.
I have tested the schemas with a deployed DynamoDB table & Kinesis Stream and it works perfectly!
It's still a bit cumbersome to extend the DynamoDB item with your own schema because it's nested and because we don't have an helper to marshall the items (#3194), but we'll address these soon-ish.
Thank you!
2 tasks
…eam-events-via-Kinesis-Data-Stream
… structured clones
…eam-events-via-Kinesis-Data-Stream
dreamorosi
approved these changes
Nov 22, 2024
…eam-events-via-Kinesis-Data-Stream
|
am29d
deleted the
issue3193/Feature-request-parse-DynamoDB-Stream-events-via-Kinesis-Data-Stream
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds built-in schema for DynamoDB -> Kinesis -> Lambda event.
Changes
KinesisDynamoDBStreamschema with a dedicated record schemaI have decided to add a built-in schema, instead of the envelope because we already follow this convention with SQS-SNS, FireHose-SQS and other chained events.
I have decided not to change the
decompresslogic (only the typo), because I want to address this issue in a separate PR. There are various cases what can be wrapped into a Kinesis stream and I'd like to take a step back and see how we can create a better structure that will allow us to compose more easily.Issue number: closes #3193
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.