Skip to content

feat: add resetKeys to LoggerInterface type #3213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

ralbertazzi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

Adding missing function definition resetKeys() to the LoggerInterface function

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: #3212


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@ralbertazzi ralbertazzi requested a review from a team October 17, 2024 11:41
@ralbertazzi ralbertazzi requested a review from a team as a code owner October 17, 2024 11:41
@boring-cyborg boring-cyborg bot added the logger This item relates to the Logger Utility label Oct 17, 2024
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Oct 17, 2024
Copy link

boring-cyborg bot commented Oct 17, 2024

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #typescript channel on our Powertools for AWS Lambda Discord: Invite link

Copy link

Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting the PR and help fix the issue!

@dreamorosi dreamorosi merged commit 385cc27 into aws-powertools:main Oct 17, 2024
21 checks passed
Copy link

boring-cyborg bot commented Oct 17, 2024

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Copy link
Contributor

@aws-powertools/lambda-typescript No related issues found. Please ensure 'pending-release' label is applied before releasing.

@github-actions github-actions bot added the feature PRs that introduce new features or minor changes label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature PRs that introduce new features or minor changes logger This item relates to the Logger Utility size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: add missing resetKeys method to LoggerInterface
2 participants