-
Notifications
You must be signed in to change notification settings - Fork 154
refactor(logger): use LogLevelThreshold
constant inside Logger
class
#3133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(logger): use LogLevelThreshold
constant inside Logger
class
#3133
Conversation
|
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @arnabrahman, appreciate it.
About the test coverage problem, I have opened an issue (#3134) and will look into fixing it asap. Thanks for reporting it and apologies for the confusion during the work.
Summary
The PR removes the local
LogLevelThreshold
object fromLogger
class and replaces it withLogLevelThreshold
constant.Changes
LogLevelThreshold
object from the Logger class and replaced it with theLogLevelThreshold
constant.LogLevelThresholds
type and its exports.private logLevel
property of theLogger
class now uses the value fromLogLevelThreshold
instead of hardcoding the value.Issue number: #2525
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.