-
Notifications
You must be signed in to change notification settings - Fork 154
test(maintenance): improve assertions on traces & logs #3012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Passing integration tests on this branch: https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/10671082450 |
Co-authored-by: Alexander Schueren <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. The code duplication is a bit high for all the tracer tests (middy, decorator, manual), but I think we can address it in a different PR. We have many such cases where we need to check the same outcomes for various setups.
I agree. We have upcoming PRs where we'll work on streamlining similar to what we did in other areas in the past few weeks. For now seeing as the PR was already large I decided to not act on this. |
Summary
Changes
This PR improves and simplifies the helpers used to retrieve AWS X-Ray trace data that are used in the integration tests. As a result of this, the integration tests for the utility are also slightly simplified due to the helpers handling more of the data retrieval & validation from the X-Ray API.
The PR also extends some assertions in the Idempotency tests to more flexibly assert timeouts in Amazon CloudWatch Logs.
While working on this, I have also updated the Dependabot config so that it targets the
@aws-cdk/cli-lib-alpha
(dependency ofpackages/testing
) as it had fallen behind on updates and was no longer compatible with the more recent AWS CDK installed version.Issue number: #3011
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.