Skip to content

test(maintenance): improve assertions on traces & logs #3012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 4, 2024

Conversation

dreamorosi
Copy link
Contributor

@dreamorosi dreamorosi commented Sep 2, 2024

Summary

Changes

Please provide a summary of what's being changed

This PR improves and simplifies the helpers used to retrieve AWS X-Ray trace data that are used in the integration tests. As a result of this, the integration tests for the utility are also slightly simplified due to the helpers handling more of the data retrieval & validation from the X-Ray API.

The PR also extends some assertions in the Idempotency tests to more flexibly assert timeouts in Amazon CloudWatch Logs.

While working on this, I have also updated the Dependabot config so that it targets the @aws-cdk/cli-lib-alpha (dependency of packages/testing) as it had fallen behind on updates and was no longer compatible with the more recent AWS CDK installed version.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: #3011


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Sep 2, 2024
@dreamorosi dreamorosi requested a review from a team September 2, 2024 16:44
@dreamorosi dreamorosi requested a review from a team as a code owner September 2, 2024 16:44
@boring-cyborg boring-cyborg bot added dependencies Changes that touch dependencies, e.g. Dependabot, etc. tests PRs that add or change tests labels Sep 2, 2024
@pull-request-size pull-request-size bot added the size/XXL PRs with 1K+ LOC, largely documentation related label Sep 2, 2024
@dreamorosi dreamorosi linked an issue Sep 2, 2024 that may be closed by this pull request
2 tasks
@dreamorosi
Copy link
Contributor Author

Copy link

sonarqubecloud bot commented Sep 4, 2024

@dreamorosi dreamorosi requested a review from am29d September 4, 2024 15:28
Copy link
Contributor

@am29d am29d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. The code duplication is a bit high for all the tracer tests (middy, decorator, manual), but I think we can address it in a different PR. We have many such cases where we need to check the same outcomes for various setups.

@dreamorosi
Copy link
Contributor Author

The code duplication is a bit high for all the tracer tests (middy, decorator, manual), but I think we can address it in a different PR

I agree. We have upcoming PRs where we'll work on streamlining similar to what we did in other areas in the past few weeks. For now seeing as the PR was already large I decided to not act on this.

@dreamorosi dreamorosi merged commit 6116607 into main Sep 4, 2024
11 checks passed
@dreamorosi dreamorosi deleted the chore/e2e_test_assertions branch September 4, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc. size/XXL PRs with 1K+ LOC, largely documentation related tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: improve e2e assertions on traces & idempotency
2 participants