fix(tracer): include request pathname in trace data #2955
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR modifies the internal implementation of the Tracer patching for the
fetch
request module so that it includes the pathname of a request in the segment data.As reported in the linked issue, the current implementation only records the host name, so a request to
https://aws.amazon.com/free
would generate a segment similar to this:while it should have generated one like this:
Notice how the
http.request.url
includes both the path and protocol.The PR also modifies and adds some unit tests to account for the updated logic.
Issue number: closes #2954
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.