-
Notifications
You must be signed in to change notification settings - Fork 154
chore(maintenance): migrate logger utility to biome #2813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this!
I've just left one comment and then it's good to merge :)
When you can, could you also pls leave a comment under the linked issue (& all others you're working or want to pick up) so that I can assign them to you? Thanks! |
@dreamorosi I'll check the sonarcloud issue and comment on the issues i'd like to pick :) Thank you for your support ❤️ Really awesome opportunity for me to learn about biome and to (hopefully) help you a bit out here :) |
That's great - yes, like I said in the other issue any help is more than welcome! It seems that I made a mistake and that I was too hasty in my review. I saw a couple more instances where the comment block at the top of the test files got shifted down due to import sorting from Biome (the same is happening in other PRs I've worked). I think it'd be helpful if you could go through all the /**
* Test logger basic features
*
* @group e2e/logger/logEventEnvVarSetting
*/ Thanks! |
|
@dreamorosi Thanks for the review!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing all the feedback and for helping improve the project!
@aws-powertools/lambda-typescript No related issues found. Please ensure 'pending-release' label is applied before releasing. |
Summary
Changes
Adds biome to the logger package. Closes #2798
Issue number: 2798
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.