Skip to content

chore(maintenance): migrate logger utility to biome #2813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 23, 2024

Conversation

daschaa
Copy link
Contributor

@daschaa daschaa commented Jul 23, 2024

Summary

Changes

Adds biome to the logger package. Closes #2798

Issue number: 2798


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@daschaa daschaa requested a review from a team July 23, 2024 12:42
@daschaa daschaa requested a review from a team as a code owner July 23, 2024 12:42
@boring-cyborg boring-cyborg bot added dependencies Changes that touch dependencies, e.g. Dependabot, etc. internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) logger This item relates to the Logger Utility tests PRs that add or change tests labels Jul 23, 2024
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Jul 23, 2024
@daschaa daschaa changed the title chore(logger): add biome to project chore(maintenance): migrate logger utility to biome Jul 23, 2024
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

I've just left one comment and then it's good to merge :)

@dreamorosi
Copy link
Contributor

@daschaa - Could you also take a look at the SonarCloud finding here?

I'll check your other two comments in the meanwhile - need to clone the repo to answer definitively.

@dreamorosi
Copy link
Contributor

When you can, could you also pls leave a comment under the linked issue (& all others you're working or want to pick up) so that I can assign them to you? Thanks!

@daschaa
Copy link
Contributor Author

daschaa commented Jul 23, 2024

@dreamorosi I'll check the sonarcloud issue and comment on the issues i'd like to pick :) Thank you for your support ❤️ Really awesome opportunity for me to learn about biome and to (hopefully) help you a bit out here :)

@dreamorosi
Copy link
Contributor

That's great - yes, like I said in the other issue any help is more than welcome!

It seems that I made a mistake and that I was too hasty in my review. I saw a couple more instances where the comment block at the top of the test files got shifted down due to import sorting from Biome (the same is happening in other PRs I've worked).

I think it'd be helpful if you could go through all the packages/logger/tests/**/*.test.ts files and make sure that comments like this are at the very top:

/**
 * Test logger basic features
 *
 * @group e2e/logger/logEventEnvVarSetting
 */

Thanks!

Copy link

@daschaa
Copy link
Contributor Author

daschaa commented Jul 23, 2024

@dreamorosi Thanks for the review!

  • I have put the grouping comment to the top of each test file (btw I did not know about this feature in jest, really nice)
  • I have removed the suppression of the variable override and introduced the local variable like you suggested
  • I have fixed the SonarCloud finding by changing from a traditional for loop to a for...of loop

@dreamorosi dreamorosi self-requested a review July 23, 2024 13:54
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing all the feedback and for helping improve the project!

@dreamorosi dreamorosi merged commit d239d1c into aws-powertools:main Jul 23, 2024
10 checks passed
Copy link
Contributor

@aws-powertools/lambda-typescript No related issues found. Please ensure 'pending-release' label is applied before releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc. internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) logger This item relates to the Logger Utility size/L PRs between 100-499 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: add biome to project (logger)
2 participants