Skip to content

docs(batch): review API docs & README #2562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 23, 2024
Merged

docs(batch): review API docs & README #2562

merged 5 commits into from
May 23, 2024

Conversation

dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR overhauls the JSDoc comments on each type, function, class, and method of the Batch Processing utility so that it provides better and relevant info to customers using the API docs or wanting to get contextual info within their IDE.

The work here followed the guidelines established in the linked issue and its parent, and also refreshes the README file for the utility to be more focused and in line with the new style.

Finally, while there, I also made some minor touch-ups to the code snippets of the utility so that they're more concise.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #2380


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this May 21, 2024
@dreamorosi dreamorosi requested a review from a team May 21, 2024 05:33
@dreamorosi dreamorosi requested a review from a team as a code owner May 21, 2024 05:33
@boring-cyborg boring-cyborg bot added batch This item relates to the Batch Processing Utility dependencies Changes that touch dependencies, e.g. Dependabot, etc. internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels May 21, 2024
@pull-request-size pull-request-size bot added the size/XL PRs between 500-999 LOC, often PRs that grown with feedback label May 21, 2024
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label May 21, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dreamorosi dreamorosi merged commit 2a5046e into main May 23, 2024
12 checks passed
@dreamorosi dreamorosi deleted the docs/batch branch May 23, 2024 16:04
Copy link

@Vman909 Vman909 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch This item relates to the Batch Processing Utility dependencies Changes that touch dependencies, e.g. Dependabot, etc. documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/XL PRs between 500-999 LOC, often PRs that grown with feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: review API docs & README for Batch
3 participants