chore(parameters): Use AppConfig L2 constructs for integration tests #2524
Conversation
daschaa
changed the title
|
Preliminary run for the integration tests is green: https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/9086242800 Whenever you want me to run it again, just tag me and I'll do it (it's manual for PR coming from forks). |
|
Like before, if you could leave a comment under the original issue I'll assign it to you - so that everyone knows the issue is taken. |
|
@dreamorosi Thanks for your fast feedback, I really appreciate it! I just marked this PR as a draft because I hadn't got the time to run the integration tests, I just compared the synthed output and tried to remodel the current behavior. So did you let the integration tests run with the current state of this PR? Can I mark it as "Ready for Review" already? |
|
Yes, I ran it with the latest commit around the time I left my comment. You can mark it as ready whenever you're ready - no rush from my side. |
There was a problem hiding this comment.
Left one minor comment here. Once it's addressed I'll run the integration tests again and if they're green I'll merge it.
Thanks again for your contribution!
Co-authored-by: Andrea Amorosi <[email protected]>
|
There was a problem hiding this comment.
I have ran the integration tests once again and they're green.
Thank you so much for working on this PR!
Summary
Changes
This PR implements the L2 constructs for the integration tests in the parameters package. Closes #2396
Issue number: #2396
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.