Skip to content

chore(ci): Aggregate lint-staged in top package.json #2520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2024

Conversation

daschaa
Copy link
Contributor

@daschaa daschaa commented May 14, 2024

Summary

Changes

In this PR the suggested aggregation of the lint-staged configuration into the top package.json is implemented. Closes #2312

Issue number: #2312


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@daschaa daschaa requested a review from a team May 14, 2024 17:59
@daschaa daschaa requested a review from a team as a code owner May 14, 2024 17:59
@boring-cyborg boring-cyborg bot added the dependencies Changes that touch dependencies, e.g. Dependabot, etc. label May 14, 2024
@pull-request-size pull-request-size bot added the size/M PR between 30-99 LOC label May 14, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

This comment has been minimized.

@github-actions github-actions bot added do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels May 14, 2024
@dreamorosi dreamorosi removed do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels May 14, 2024
@dreamorosi
Copy link
Contributor

Hey @daschaa, nice to see you again!

Thank you for opening this PR! Going to merge it as soon as the CI completes.

--

Also, ignore the comment about the missing issue that another automation left. It was triggered by mistake due to a formatting issue.

Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@dreamorosi dreamorosi merged commit c9c29a2 into aws-powertools:main May 14, 2024
20 checks passed
@dreamorosi
Copy link
Contributor

If possible, could I please ask you to leave a comment under the original issue, so that I can assign it to you? It's just for tracking purposes and GitHub doesn't let me assign it to users that have not interacted with it.

@daschaa
Copy link
Contributor Author

daschaa commented May 14, 2024

Hey Andrea, thanks for the fast review, really appreciate it! :)
I'll comment under the original issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Changes that touch dependencies, e.g. Dependabot, etc. size/M PR between 30-99 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: refactor lint-staged configuration
2 participants