Skip to content

chore: fix linting #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 30, 2021
Merged

chore: fix linting #247

merged 3 commits into from
Nov 30, 2021

Conversation

flochaz
Copy link
Contributor

@flochaz flochaz commented Nov 29, 2021

Description of your changes

This change only format files to comply with linting rules.

How to verify this change

Check this PR actions: https://github.com/awslabs/aws-lambda-powertools-typescript/runs/4355498247?check_suite_focus=true

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@flochaz flochaz changed the title Chore/cicd improvment chore: fix linting Nov 29, 2021
saragerion
saragerion approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@saragerion saragerion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flochaz flochaz merged commit f6d832d into main Nov 30, 2021
@flochaz flochaz deleted the chore/cicdImprovment branch November 30, 2021 10:04
@dreamorosi dreamorosi mentioned this pull request Dec 10, 2021
Closed
@heitorlessa heitorlessa added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamorosi dreamorosi dreamorosi approved these changes

@saragerion saragerion saragerion approved these changes

Assignees
No one assigned
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flochaz @dreamorosi @saragerion @heitorlessa