Skip to content

docs(commons): refresh API docs & README #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 2, 2024

Conversation

dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR introduces updates to the API docs & README file for the commons utility.

The main focus of the changes is to document every function/method/type in a consistent and informative way so that the API docs are populated with an even level of details.

Likewise, when it comes to the README file of the utility, I have removed a lot of the fluff and kept actionable and useful info to get a high level view of the package specifically, and then about the project after that.

The rationale behind this change is that the README file, which is used as "cover page" for the utility in the API docs and on npmjs.com, should give a quick overview of what the package is about first and foremost.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: #2377


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Apr 29, 2024
@dreamorosi dreamorosi requested a review from a team April 29, 2024 15:43
@dreamorosi dreamorosi requested a review from a team as a code owner April 29, 2024 15:43
@dreamorosi dreamorosi linked an issue Apr 29, 2024 that may be closed by this pull request
4 tasks
@boring-cyborg boring-cyborg bot added commons This item relates to the Commons Utility internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Apr 29, 2024
@pull-request-size pull-request-size bot added the size/XL PRs between 500-999 LOC, often PRs that grown with feedback label Apr 29, 2024
@dreamorosi dreamorosi marked this pull request as draft April 29, 2024 15:48
@boring-cyborg boring-cyborg bot added the tests PRs that add or change tests label Apr 30, 2024
@dreamorosi dreamorosi marked this pull request as ready for review April 30, 2024 07:12
Copy link

sonarqubecloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dreamorosi dreamorosi merged commit 3f9cfd8 into main May 2, 2024
11 checks passed
@dreamorosi dreamorosi deleted the 2377-maintenance-review-api-docs-commons branch May 2, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commons This item relates to the Commons Utility internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/XL PRs between 500-999 LOC, often PRs that grown with feedback tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: review API docs & README for Commons
2 participants