Skip to content

chore(maintenance): revamp PR & issue templates #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

This PR introduces changes to the PR and Issue templates used to render them.

As discussed in the linked issue, the goal is to make the PR template less verbose and cumbersome while still maintaining all the sections & callouts we need.

The changes introduced are in line with the ones discussed in the issue.

Related issues, RFCs

Issue number: closes #2411

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi requested a review from a team April 25, 2024 10:04
@dreamorosi dreamorosi requested a review from a team as a code owner April 25, 2024 10:04
@dreamorosi dreamorosi self-assigned this Apr 25, 2024
@boring-cyborg boring-cyborg bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Apr 25, 2024
@pull-request-size pull-request-size bot added the size/M PR between 30-99 LOC label Apr 25, 2024
Copy link
Contributor

@am29d am29d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks, otherwise good to merge.

@dreamorosi dreamorosi requested a review from am29d April 25, 2024 10:51
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@dreamorosi dreamorosi merged commit 936d5e9 into main Apr 25, 2024
12 checks passed
@dreamorosi dreamorosi deleted the chore/pr_issue_templates branch April 25, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/M PR between 30-99 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: revamp issue & PR templates
2 participants