fix(idempotency): return correct value from in-memory cache #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
idempotency
…read-correct-value
|
am29d
deleted the
2309-bug-idempotency-in-memory-cache-doesnt-read-correct-value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR fixes a bug in the Idempotency utility that caused retries performed while the utility's in-memory cache was enabled to be rejected as "already in-progress" rather than returning the value from the previous execution.
Due to this bug happening exclusively on repeated (aka subsequent) idempotent requests it's highly unlikely that customers might have experienced data loss but instead they would have observed an artificially high number of
IdempotencyAlreadyInProgressErrorerrors as if the previous execution was not yet complete, which is still not great.The PR addresses the bug by returning the value from cache whenever one is found. It also addresses a gap in our tests that was evidenced by us not catching the bug by enabling the
useLocalCachesetting in some existing cases both in the unit & integration tests.Related issues, RFCs
Issue number: #2309
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.