Skip to content

feat(logger): improve regex in stack trace parsing #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 11, 2024
Merged

feat(logger): improve regex in stack trace parsing #2194

merged 3 commits into from
Mar 11, 2024

Conversation

karthikeyanjp
Copy link
Contributor

@karthikeyanjp karthikeyanjp commented Mar 9, 2024 •
edited by dreamorosi
Loading

Description of your changes

This PR improves the regex pattern used to the determine the location of a error in a stack-trace. The newer pattern will support the strackframe locations mentioned in the nodejs documentation.

References:

Related issues, RFCs

Issue number: #2121

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@karthikeyanjp karthikeyanjp requested a review from a team March 9, 2024 20:11
@karthikeyanjp karthikeyanjp requested a review from a team as a code owner March 9, 2024 20:11
@boring-cyborg boring-cyborg bot added the tests PRs that add or change tests label Mar 9, 2024
@pull-request-size pull-request-size bot added the size/M PR between 30-99 LOC label Mar 9, 2024
@karthikeyanjp karthikeyanjp force-pushed the improv/stacktrace-location-regex branch from c76dba6 to a7290a3 Compare March 9, 2024 20:14
@boring-cyborg boring-cyborg bot added the logger This item relates to the Logger Utility label Mar 9, 2024
@karthikeyanjp karthikeyanjp marked this pull request as draft March 9, 2024 20:16
@karthikeyanjp karthikeyanjp force-pushed the improv/stacktrace-location-regex branch from a7290a3 to c58f1cf Compare March 9, 2024 20:21
@karthikeyanjp karthikeyanjp force-pushed the improv/stacktrace-location-regex branch from c58f1cf to 902152e Compare March 9, 2024 22:06
@pull-request-size pull-request-size bot added size/L PRs between 100-499 LOC and removed size/M PR between 30-99 LOC labels Mar 9, 2024
@karthikeyanjp karthikeyanjp changed the title improve(logger): improve regex in stack trace parsing feat(logger): improve regex in stack trace parsing Mar 9, 2024
@karthikeyanjp karthikeyanjp mentioned this pull request Mar 9, 2024
Closed
2 tasks
@karthikeyanjp karthikeyanjp marked this pull request as ready for review March 9, 2024 22:25
@github-actions github-actions bot added the feature PRs that introduce new features or minor changes label Mar 10, 2024
@dreamorosi dreamorosi linked an issue Mar 11, 2024 that may be closed by this pull request
Feature request: improve regex in stack trace parsing #2121
Closed
2 tasks
@dreamorosi dreamorosi self-requested a review March 11, 2024 13:09
dreamorosi
dreamorosi requested changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, I have left just one comment about the regex that I didn't notice when writing the issue but I noticed during review.

Looking forward to merge the PR!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dreamorosi dreamorosi self-requested a review March 11, 2024 18:50
dreamorosi
dreamorosi approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing this improvement, appreciate your time.

I have marked a few more issues in the Logger utility with the help-wanted label in case you're interested, here's a filtered list.

@dreamorosi dreamorosi merged commit ebe5eef into aws-powertools:main Mar 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamorosi dreamorosi dreamorosi approved these changes

Assignees

@karthikeyanjp karthikeyanjp

Labels
feature PRs that introduce new features or minor changes logger This item relates to the Logger Utility size/L PRs between 100-499 LOC tests PRs that add or change tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: improve regex in stack trace parsing
2 participants
@karthikeyanjp @dreamorosi