Skip to content

fix(ci): create one layer artifact per region & merge #2095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 20, 2024
Merged

fix(ci): create one layer artifact per region & merge #2095

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0db0ba0
chore(ci): restore layer arn artifact uploads
dreamorosi Feb 20, 2024
e397b7f
chore(ci): step name
dreamorosi Feb 20, 2024
8f96001
chore(ci): remove artifact name
dreamorosi Feb 20, 2024
f59c6eb
chore(ci): remove trailing slash from path
dreamorosi Feb 20, 2024
b8d4879
chore(ci): add comment
dreamorosi Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/publish_layer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,12 @@ jobs:
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
with:
ref: ${{ github.sha }}
- name: Download CDK layer artifact
- name: Download CDK layer artifacts
uses: actions/download-artifact@eaceaf801fd36c7dee90939fad912460b18a1ffe # v4.1.2
with:
name: cdk-layer-stack
path: cdk-layer-stack/
path: cdk-layer-stack
pattern: cdk-layer-stack-*
merge-multiple: true
- name: Replace layer versions in documentation
run: |
ls -la cdk-layer-stack/
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/reusable_deploy_layer_stack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,9 @@ jobs:
if: ${{ inputs.stage == 'PROD' }}
uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
with:
name: cdk-layer-stack
name: cdk-layer-stack-${{ matrix.region }}
path: ./cdk-layer-stack/* # NOTE: upload-artifact does not inherit working-directory setting.
if-no-files-found: error
retention-days: 1
overwrite: true
- name: CDK deploy canary
run: npm run cdk -w layers -- deploy --app cdk.out --context region=${{ matrix.region }} 'CanaryStack' --require-approval never --verbose --outputs-file cdk-outputs.json