-
Notifications
You must be signed in to change notification settings - Fork 154
feat(idempotency): return existing record in IdempotencyValidationError #2059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(idempotency): return existing record in IdempotencyValidationError #2059
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening this PR, looks good to me!
Hi @kevin-secrist, I'm looking at some issues on the integration tests around the Idempotency package. I don't think they're related to the changes in this PR but just to be safe I'd like to take a bit more time to identify the issue before merging this PR. |
I was able to isolate the issue on the integration tests and confirm it's not related to the changes in this PR. I'm opening another PR to fix them, and once that's merged we'll run the tests once again and merge this. |
|
Integration tests are passing, thank you for the patience: https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/7930491156 |
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Description of your changes
Exposes the
IdempotencyRecord
which failed payload validation as a property on the thrownIdempotencyValidationError
.Related issues, RFCs
Issue number: closes #2048
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.