Skip to content

chore(maintenance): group CDK cli with other CDK dependencies #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

This PR adds the aws-cdk dependency to the Dependabot group that previously contained only aws-cdk-lib and dependencies starting with the @aws-cdk/** pattern (experimental constructs). In some less common cases, an update of library might not work with the cli, so bumping these two dependencies together makes more sense.

Related issues, RFCs

Issue number: #1858

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Jan 25, 2024
@dreamorosi dreamorosi requested a review from a team January 25, 2024 14:56
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Jan 25, 2024
@dreamorosi dreamorosi linked an issue Jan 25, 2024 that may be closed by this pull request
2 tasks
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@am29d am29d merged commit 4e83a57 into main Jan 25, 2024
@am29d am29d deleted the chore/refine_cdk_dependency_group branch January 25, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: fine tune Dependabot configuration
2 participants