Skip to content

chore(ci): allow deps-dev for semantic PR #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Jan 9, 2024

Description of your changes

Adding deps-dev for semantic PR config.

Related issues, RFCs

Issue number: #1859

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@am29d am29d requested a review from a team January 9, 2024 10:40
@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Jan 9, 2024
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Jan 9, 2024
@am29d am29d requested review from heitorlessa and removed request for a team January 9, 2024 10:40
@am29d am29d self-assigned this Jan 9, 2024
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@am29d am29d linked an issue Jan 9, 2024 that may be closed by this pull request
2 tasks
@am29d am29d merged commit 74ae163 into main Jan 9, 2024
@am29d am29d deleted the chore/1859-semantic-pr branch January 9, 2024 11:49
@am29d am29d removed the request for review from heitorlessa January 9, 2024 11:49
@@ -31,6 +31,7 @@ scopes:
- internal
- maintenance
- deps
- deps-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, didn't foresee that when adding deps; tks for fixing it!

dreamorosi pushed a commit that referenced this pull request Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Allow dependabot PRs in Semantic PR config
2 participants