Skip to content

chore(docs): fix layer version in CDK example #1805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

daschaa
Copy link
Contributor

@daschaa daschaa commented Nov 29, 2023

Description of your changes

The version for the layer was changed from version 18 to 24.

Related issues, RFCs

Issue number: fixes #1793

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@daschaa daschaa requested a review from a team November 29, 2023 20:04
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Nov 29, 2023
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Nov 29, 2023
Copy link

boring-cyborg bot commented Nov 29, 2023

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #typescript channel on our Powertools for AWS Lambda Discord: Invite link

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dreamorosi
Copy link
Contributor

dreamorosi commented Nov 29, 2023

Hi @daschaa, thank you for opening this PR.

if you could please leave a comment under the linked issue I'll assign it to you before merging (GitHub doesn't allow me to assign it before one interacts with it).

Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@dreamorosi dreamorosi changed the title fix(docs): CDK example has incorrect layer version chore(docs): fix layer version in CDK example Nov 29, 2023
@daschaa
Copy link
Contributor Author

daschaa commented Nov 29, 2023

@dreamorosi Done 😊

@dreamorosi dreamorosi merged commit d17d427 into aws-powertools:main Nov 29, 2023
Copy link

boring-cyborg bot commented Nov 29, 2023

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: update layer art in CDK example
2 participants