chore(ci): sets base permissions on all workflows #1801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds pull requests write permission add permissions for packages, id-token add permissions add permissions all the permissions!
|
Kudos, SonarCloud Quality Gate passed!
|
dreamorosi
reviewed
Nov 24, 2023
| @@ -32,6 +40,9 @@ jobs: | |||
| env: | |||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
| release_label_on_merge: | |||
| permissions: | |||
| pull-requests: read | |||
| contents: write | |||
There was a problem hiding this comment.
Can this contents: write be scoped down only to issues?
There was a problem hiding this comment.
With issues: write yes, but removing content would not prevent from merge, or?
dreamorosi
reviewed
Nov 24, 2023
2 tasks
9 tasks
dreamorosi
pushed a commit
that referenced
this pull request
Jan 27, 2024
adds pull requests write permission add permissions for packages, id-token add permissions add permissions all the permissions!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds a root
permissionsto the base of every workflow that was missing one.Related issues, RFCs
Issue number: #1799
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.