chore(maintenance): improve Gitpod config #1782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
internal
|
Kudos, SonarCloud Quality Gate passed!
|
2 tasks
dreamorosi
added a commit
that referenced
this pull request
Nov 20, 2023
* chore(maintenance): pin node 18 in Gitpod * chore: fix nvm & make sam install quiet * chore: fix nvm command * chore: switch to fem * chore: add Dockerfile with pinned version * chore: change to custom docker file * chore: remove redundant command * chore: move SAM install to docker file * chore: remove SAM instructions from init phase * chore: fix install command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR modifies the Gitpod configuration to pin a specific base image for the workspace and configure dependencies in it.
Prior to this PR Gitpod was starting a workspace using the latest image available, which in some cases like now it's not desirable. Following the same practices that we use in other areas like dependencies and GitHub Actions, I have changed the configuration so that we are pinning a specific version of a specific Docker image identified by its
shanumber. I got this idea from the Python repository which does the same.The new setup specifies a Dockerfile which uses the base workspace image and builds on top of it. I decided not to use the node image provided by Gitpod because I wanted to customize the setup of the Node.js version manager using
fnminstead ofnvm. In doing so I have also moved the SAM CLI install to the Dockerfile.Related issues, RFCs
Issue number: #1781
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.