Skip to content

docs: remove beta warning from batch and idempotency readme #1696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 20, 2023
Merged

docs: remove beta warning from batch and idempotency readme #1696

merged 5 commits into from
Sep 20, 2023

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Sep 20, 2023 •
edited
Loading

Description of your changes

This PR removes the beta warning from the README in batch and idemoptency utility.

Related issues, RFCs

Issue number: closes #1690

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@am29d am29d requested a review from a team September 20, 2023 10:42
@boring-cyborg boring-cyborg bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Sep 20, 2023
@pull-request-size pull-request-size bot added the size/S PR between 10-29 LOC label Sep 20, 2023
@github-actions
Copy link
Contributor

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@github-actions github-actions bot added do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Sep 20, 2023
@dreamorosi
Copy link
Contributor

Could you also remove the (beta) from this file?

https://github.com/aws-powertools/powertools-lambda-typescript/blob/main/README.md?plain=1#L38

After that, ship it!

@am29d
Copy link
Contributor Author

am29d commented Sep 20, 2023

Could you also remove the (beta) from this file?

https://github.com/aws-powertools/powertools-lambda-typescript/blob/main/README.md?plain=1#L38

After that, ship it!

Good catch!

@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Sep 20, 2023
@am29d
Copy link
Contributor Author

am29d commented Sep 20, 2023

Remove more beta flags and added utilities to the main doc page.

dreamorosi
dreamorosi approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pull-request-size pull-request-size bot added size/M PR between 30-99 LOC and removed size/S PR between 10-29 LOC labels Sep 20, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dreamorosi dreamorosi removed do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Sep 20, 2023
@dreamorosi dreamorosi merged commit ea94200 into main Sep 20, 2023
@dreamorosi dreamorosi deleted the 1690-remove-beta-warning-batch-idempotency branch September 20, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamorosi dreamorosi dreamorosi approved these changes

Assignees

@am29d am29d

Labels
documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/M PR between 30-99 LOC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: remove beta warning from README files
2 participants
@am29d @dreamorosi