feat(batch): simplify BatchProcessor
for async and sync functions
#1682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR flips the syntax of the
AsyncBatchProcessor
andBatchProcessor
. During the implementation we oriented around the python implementation and replicated the names. In Node ecosystem the case with async and sync is the opposite. Most of the function from libraries are async and there are cases where async
suffix on a function indicates that it's a synchronous function.Therefore we rename
AsyncBatchProcessor
toBatchProcessor
andBatchProcessor
toBatchProcessorSync
.Related issues, RFCs
Issue number: closes #1677
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.