Skip to content

chore(ci): pin npm 9.x in workflows #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2023
Merged

chore(ci): pin npm 9.x in workflows #1666

merged 1 commit into from
Sep 1, 2023

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

As discussed in the linked issue, npm recently reached version 10 which drops support for Node.js 14 and 16.

In order to continue running our CI, this PR pins the npm version to 9.x for all runtimes.

Related issues, RFCs

Issue number: closes #1665

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi requested a review from a team September 1, 2023 16:30
@dreamorosi dreamorosi self-assigned this Sep 1, 2023
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Sep 1, 2023
@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Sep 1, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dreamorosi dreamorosi merged commit 50b6ace into main Sep 1, 2023
@dreamorosi dreamorosi deleted the chore/pin_npm branch September 1, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: pin npm 9.x in our CI
1 participant