Skip to content

chore(maintenance): remove parameters utility from layer bundling and layers e2e tests #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2023
Merged

chore(maintenance): remove parameters utility from layer bundling and layers e2e tests #1599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
523d709
remove parameter from e2e tests
Jul 11, 2023
7ded2a0
remove parameters from canary stack as well
Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/scripts/setup_tmp_layer_files.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ npm init -y
npm i \
@aws-lambda-powertools/logger@$VERSION \
@aws-lambda-powertools/metrics@$VERSION \
@aws-lambda-powertools/tracer@$VERSION \
@aws-lambda-powertools/parameters@$VERSION
@aws-lambda-powertools/tracer@$VERSION
rm -rf node_modules/@types \
package.json \
package-lock.json
Expand Down
4 changes: 1 addition & 3 deletions layers/src/canary-stack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,17 +41,15 @@ export class CanaryStack extends Stack {
'../tests/e2e/layerPublisher.class.test.functionCode.ts'
),
handler: 'handler',
runtime: Runtime.NODEJS_18_X,
runtime: Runtime.NODEJS_14_X,
functionName: `canary-${suffix}`,
timeout: Duration.seconds(30),
bundling: {
externalModules: [
// don't package these modules, we want to pull them from the layer
'aws-sdk',
'@aws-lambda-powertools/logger',
'@aws-lambda-powertools/metrics',
'@aws-lambda-powertools/tracer',
'@aws-lambda-powertools/parameters',
'@aws-lambda-powertools/commons',
],
},
Expand Down
2 changes: 0 additions & 2 deletions layers/tests/e2e/layerPublisher.class.test.functionCode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,12 @@ import { readFileSync } from 'node:fs';
import { Logger } from '@aws-lambda-powertools/logger';
import { Metrics } from '@aws-lambda-powertools/metrics';
import { Tracer } from '@aws-lambda-powertools/tracer';
import { SSMProvider } from '@aws-lambda-powertools/parameters/ssm';

const logger = new Logger({
logLevel: 'DEBUG',
});
const metrics = new Metrics();
const tracer = new Tracer();
new SSMProvider();

export const handler = (): void => {
// Check that the packages version matches the expected one
Expand Down