Skip to content

chore(ci): added cached dependencies to e2e workflow #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2023

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

As described in the linked issue, some recent changes made to the way the packages were built broke the workflow that runs the integration tests. This PR applies the same changes by using the shared GitHub Action that is tasked with restoring the dependencies from cache & building the project.

Related issues, RFCs

Issue number: #1516

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi requested a review from a team June 20, 2023 09:07
@dreamorosi dreamorosi self-assigned this Jun 20, 2023
@dreamorosi dreamorosi merged commit 043b4ad into main Jun 20, 2023
@dreamorosi dreamorosi deleted the chore/cached_node_e2e branch June 20, 2023 10:23
@dreamorosi dreamorosi linked an issue Jun 20, 2023 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: use cached node_modules in integration tests workflow
1 participant