Skip to content

Maintenance: use cached node_modules in integration tests workflow #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 2 tasks
dreamorosi opened this issue Jun 20, 2023 · 1 comment · Fixed by #1517
Closed
1 of 2 tasks

Maintenance: use cached node_modules in integration tests workflow #1516

dreamorosi opened this issue Jun 20, 2023 · 1 comment · Fixed by #1517
Assignees
@dreamorosi
Labels
automation This item relates to automation confirmed The scope is clear, ready for implementation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@dreamorosi
Copy link
Contributor

Summary

In a recent PR we modified the way in which the packages in the workspace are installed and built. In doing so I forgot to update one of the workflows that is in charge of running the integration tests, which due to this misconfiguration now fails consistently.

Why is this needed?

So that we are able to run the integration tests in our CI.

Which area does this relate to?

Automation, Tests

Solution

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.
@dreamorosi dreamorosi added automation This item relates to automation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) confirmed The scope is clear, ready for implementation labels Jun 20, 2023
@dreamorosi dreamorosi self-assigned this Jun 20, 2023
@dreamorosi dreamorosi mentioned this issue Jun 20, 2023
Merged
9 tasks
@dreamorosi dreamorosi moved this from Working on it to Shipped in Powertools for AWS Lambda (TypeScript) Jun 20, 2023
@github-project-automation github-project-automation bot moved this from Shipped to Coming soon in Powertools for AWS Lambda (TypeScript) Jun 20, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi linked a pull request Jun 20, 2023 that will close this issue
chore(ci): added cached dependencies to e2e workflow #1517
Merged
9 tasks
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dreamorosi dreamorosi

Labels
automation This item relates to automation confirmed The scope is clear, ready for implementation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
Powertools for AWS Lambda (TypeScript)
Status: Shipped
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ci): added cached dependencies to e2e workflow aws-powertools/powertools-lambda-typescript
1 participant
@dreamorosi