-
Notifications
You must be signed in to change notification settings - Fork 153
chore(ci): remove GH pages #1513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
just building and pushing to S3. There’s no need to keep the branch. The backup-GH-pages branch exists as a part of the transition.
versions.json will be addressed in a PR tomorrow. I have to do the same for python too |
Ok, I don't know |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing these steps only removes the publishing of the API folder (aka API docs), the actual docs written with mkdocs
are still being pushed to the gh-pages
(currently backup-gh-pages
) branch by mike
at L81-83.
Did you leave them on purpose?
Also, if we remove the branch entirely (which I think we should), I'm not sure how the workflow is going to be able to manage the versions.json
. My understanding is that currently mike
relies on the presence of this file in the other branch, and when creating a new version/alias it appends it to the file.
If the branch is removed, then we need to make sure mike
is able to handle the file that is now present in S3.
Hey @sthulb, can we remove We have discussed to keep around the If yes, then we need to restore the changes you're proposing in this PR (& close it), so that both docs & API docs are published. If no, then we can remove the Let me know if I'm missing something, looking forward to merge/close the PR. |
Description of your changes
Remove GH pages from GH actions. We no longer use GH pages, as we have migrated to our new docs hosting already.
Related issues, RFCs
Issue number: #1509
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.