Skip to content

chore: rename project to Powertools for AWS Lambda (TypeScript) #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 31, 2023
Merged

Conversation

sthulb
Copy link
Contributor

@sthulb sthulb commented May 23, 2023

Description of your changes

Found and replaced references of the old name to the new one: Powertools for AWS Lambda (TypeScript)

Related issues, RFCs

Issue number: #1471

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added automation This item relates to automation commons This item relates to the Commons Utility documentation Improvements or additions to documentation layers Items related to the Lambda Layers pipeline dependencies Changes that touch dependencies, e.g. Dependabot, etc. internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) tests PRs that add or change tests labels May 23, 2023
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label May 23, 2023
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

I have suggested & committed a couple of changes, mostly in comments near the code where the name was redundant in the first place. In a couple of other instances where the full name was used multiple times in the same sentence/paragraph I have abbreviated the second occurrence to Powertools for AWS as agreed.

The only place that I am not sure we should change are the tiles in the docs/we_made_this.md file/page.

These are blog posts written by the community so I think we should leave the titles as they are in the original unless they are updated at some point in the future. We can still however keep the changes in our description of them, i.e.

Power-up Lambda functions with AWS Lambda Powertools for TypeScript should stay as it is since it's a title, but the sentence below that reads is post shows how to use Powertools for AWS Lambda (TypeScript) to quickly build Well-Architected serverless applications. can be updated since it's written by us.

What do you think?

@sthulb
Copy link
Contributor Author

sthulb commented May 23, 2023

I agree with the docs/we_made_this.md file, I'll revert it.

@sthulb sthulb marked this pull request as draft May 23, 2023 14:42
@sthulb sthulb marked this pull request as ready for review May 30, 2023 14:42
@dreamorosi dreamorosi merged commit 5d6ed1a into main May 31, 2023
@dreamorosi dreamorosi deleted the rename branch May 31, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation commons This item relates to the Commons Utility dependencies Changes that touch dependencies, e.g. Dependabot, etc. documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) layers Items related to the Lambda Layers pipeline size/L PRs between 100-499 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants