Skip to content

chore(docs): fix warning format in metrics documentation #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

leandrodamascena
Copy link
Contributor

Description of your changes

The rendering of this banner is wrong as the line below is missing a tab.

BEFORE
image

AFTER
image

How to verify this change

Related issues, RFCs

Issue number: #1422

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Apr 27, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 27, 2023
@dreamorosi dreamorosi changed the title docs(metrics): fix warning format in metrics documentation chore(docs): fix warning format in metrics documentation Apr 27, 2023
@dreamorosi dreamorosi self-requested a review April 27, 2023 16:50
@github-actions github-actions bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Apr 27, 2023
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting this & submitting a fix, appreciate it!

@dreamorosi dreamorosi merged commit a434adb into aws-powertools:main Apr 27, 2023
@dreamorosi dreamorosi linked an issue Apr 27, 2023 that may be closed by this pull request
2 tasks
@dreamorosi dreamorosi linked an issue Apr 27, 2023 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Fix warning in metrics documentation
2 participants