Skip to content

chore(examples): fix cdk cleanup command #1364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Peim8
Copy link
Contributor

@Peim8 Peim8 commented Mar 9, 2023

Description of your changes

Fix for issue #1311 - update README for CDK with the correct cleanup process.

How to verify this change

Related issues, RFCs

Issue number: #1311

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Mar 9, 2023
@dreamorosi dreamorosi changed the title fix: Correct cleanup command chore(examples): fix cdk cleanup command Mar 9, 2023
@dreamorosi dreamorosi linked an issue Mar 9, 2023 that may be closed by this pull request
1 task
@dreamorosi dreamorosi added the documentation Improvements or additions to documentation label Mar 9, 2023
@github-actions github-actions bot added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) bug Something isn't working labels Mar 9, 2023
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PatriciaHeimfarth, thank you so much for taking the time to contribute this fix and help improve the project.

Congrats for your first PR merged on this repo 🎉 !

@dreamorosi dreamorosi merged commit 90b7117 into aws-powertools:main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: fix cleanup command in cdk example
2 participants