Skip to content

chore: remove unused extensions from Gitpod/CodeSpaces #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

niko-achilles
Copy link
Contributor

Description of your changes

Removed tslint-plugin from gitpod definition and devcontainer definition.

  • ms-vscode.vscode-typescript-tslint-plugin

TSLint has been deprecated in favor of ESLint and the extension has also been deprecated in favor of ESLint's tooling.

How to verify this change

ms-vscode.vscode-typescript-tslint-plugin is excluded by deleting it from gitpod.ym and devcontainer.json artifacts:

Related issues, RFCs

Issue number: #1276

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Feb 19, 2023
@github-actions github-actions bot added the bug Something isn't working label Feb 19, 2023
@dreamorosi dreamorosi changed the title fix: cloud dev. env. gitpod and codespaces chore(docs): remove unused extensions Feb 19, 2023
@dreamorosi dreamorosi removed the bug Something isn't working label Feb 19, 2023
@dreamorosi dreamorosi changed the title chore(docs): remove unused extensions chore: remove unused extensions Feb 19, 2023
@dreamorosi dreamorosi added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Feb 19, 2023
@dreamorosi dreamorosi changed the title chore: remove unused extensions chore: remove unused extensions from Gitpod/CodeSpaces Feb 19, 2023
@dreamorosi dreamorosi self-requested a review February 19, 2023 15:46
@dreamorosi dreamorosi linked an issue Feb 19, 2023 that may be closed by this pull request
2 tasks
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this PR Niko, looks good to me

@dreamorosi dreamorosi merged commit 9942f07 into aws-powertools:main Feb 20, 2023
@niko-achilles niko-achilles deleted the cloud-dev-env branch February 23, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Gitpod definition - deprecated tslint plugin
2 participants