-
Notifications
You must be signed in to change notification settings - Fork 154
chore(layers): moved layer-publisher
into npm workspace
#1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dreamorosi
merged 12 commits into
main
from
1226-maintenance-make-layer-publisher-part-of-the-main-npm-workspace
Feb 20, 2023
Merged
chore(layers): moved layer-publisher
into npm workspace
#1292
dreamorosi
merged 12 commits into
main
from
1226-maintenance-make-layer-publisher-part-of-the-main-npm-workspace
Feb 20, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
am29d
requested changes
Feb 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Two small changes:
Need to fix the path to the new file here to bin/layers.ts
am29d
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR introduces changes to the files related to publishing public layers that are aimed at:
The first point has already been explained at length in the linked issue (#1226), but the TL;DR; is that by bringing this code into the workspace we can make sure all shared dependencies (which happen to be almost all of them) are version aligned. This is especially desirable given that this code is CDK-heavy and that library infamously doesn't play well with version mismatches.
In regards to the second point, the following high level changes have been made:
layer-publisher
tolayers
(same as Powertools for Python)How to verify this change
There are three areas that would allow us to definitively say the changes are correct, one of which we can't test until after merging this PR.
The first one is by looking at the checks under this PR. The tests running as a part of this PR include unit tests of the changes. The second one are integration tests, which create a layer similar to how it would be done once pushing to prod and then tests that the file bundled in it are compatible with an actual Lambda function, here's a successful passing run.
The third one would be to actually publish the layers to the production AWS environment. Doing that however would cause the layer version number to increment, which is not desirable. For this reason we have opted to defer this test to the next release date, since the two previous tests already make us confident that any potential issue will be limited to the workflows in charge of publishing the layer, rather than the layer itself.
Related issues, RFCs
Issue number: #1226
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.