Skip to content

chore: integrate parameters into CI/CD package measurement #1266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2023
Merged

chore: integrate parameters into CI/CD package measurement #1266

merged 1 commit into from
Feb 7, 2023

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Feb 1, 2023

Description of your changes

With this change we can extend the package measurement workflow for parameters package to provide feedback in PRs.

How to verify this change

Related issues, RFCs

Issue number: #1036

PR status

Is this ready for review?: NO
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Feb 1, 2023
@github-actions github-actions bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Feb 1, 2023
@dreamorosi dreamorosi self-requested a review February 6, 2023 13:54
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @am29d thank you for the bias for action on this one.

Before approving I'm going to run the workflow on this PR and see if it gets picked up correctly.

In the meanwhile, could you please leave a comment under the linked issue so that I can assign it to you (I can't until you first interact with it)?

@dreamorosi dreamorosi linked an issue Feb 6, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

📊 Package size report   No changes

File Before After
Total (Includes all files) 154.6 kB 154.6 kB
Tarball size 153.6 kB -0.01%↓153.5 kB
Unchanged files
File Size
aws-lambda-powertools-commons-1.5.1.tgz 11.0 kB
aws-lambda-powertools-logger-1.5.1.tgz 25.0 kB
aws-lambda-powertools-metrics-1.5.1.tgz 17.9 kB
aws-lambda-powertools-tracer-1.5.1.tgz 22.4 kB
commons-bundle.zip 11.5 kB
logger-bundle.zip 25.5 kB
metrics-bundle.zip 18.3 kB
tracer-bundle.zip 22.9 kB

🤖 This report was automatically generated by pkg-size-action
(options hash: 6310dd98edd623ba30d6be05fccbf930)

@dreamorosi
Copy link
Contributor

For some reason the report doesn't include the new package, however I'm not sure yet on why.

I'm going to need to look into it a bit deeper, but before I want to review the other standing PRs.

@dreamorosi dreamorosi assigned dreamorosi and am29d and unassigned dreamorosi Feb 6, 2023
@dreamorosi
Copy link
Contributor

After looking at the execution logs here it seems that the workflow uses the yaml definition that is present in the base branch and not the one in the PR (however the other changes of the PR would be included).

@dreamorosi dreamorosi self-requested a review February 7, 2023 09:44
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve & merge this one as there's no indication it won't work.

Given the low risk/low impact of this change, we can always open a new issue in case it doesn't behave as expected.

@dreamorosi dreamorosi merged commit 64771fc into aws-powertools:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: integrate into CI/CD package measurement
2 participants