-
Notifications
You must be signed in to change notification settings - Fork 154
chore: integrate parameters into CI/CD package measurement #1266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: integrate parameters into CI/CD package measurement #1266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @am29d thank you for the bias for action on this one.
Before approving I'm going to run the workflow on this PR and see if it gets picked up correctly.
In the meanwhile, could you please leave a comment under the linked issue so that I can assign it to you (I can't until you first interact with it)?
📊 Package size report No changes
🤖 This report was automatically generated by pkg-size-action |
For some reason the report doesn't include the new package, however I'm not sure yet on why. I'm going to need to look into it a bit deeper, but before I want to review the other standing PRs. |
After looking at the execution logs here it seems that the workflow uses the yaml definition that is present in the base branch and not the one in the PR (however the other changes of the PR would be included). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to approve & merge this one as there's no indication it won't work.
Given the low risk/low impact of this change, we can always open a new issue in case it doesn't behave as expected.
Description of your changes
With this change we can extend the package measurement workflow for parameters package to provide feedback in PRs.
How to verify this change
Related issues, RFCs
Issue number: #1036
PR status
Is this ready for review?: NO
Is it a breaking change?: NO
Checklist
Breaking change checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.